Re: [PATCH v3 1/3] arm: move KVM breakpoints helpers

[Peter Maydell]

On Sat, 14 Jan 2023 at 16:13, <francesco.cagnin@gmail.com> wrote:
>
> From: Francesco Cagnin <fcagnin@quarkslab.com>
>
> These helpers will be also used for HVF. Aside from reformatting a
> couple of comments for 'checkpatch.pl' and updating meson to compile
> 'hyp_gdbstub.c', this is just code motion.
>
> Signed-off-by: Francesco Cagnin <fcagnin@quarkslab.com>
> ---
>  target/arm/hyp_gdbstub.c | 242 ++++++++++++++++++++++++++++++++++
>  target/arm/internals.h   |  50 +++++++
>  target/arm/kvm64.c       | 276 ---------------------------------------
>  target/arm/meson.build   |   3 +-
>  4 files changed, 294 insertions(+), 277 deletions(-)
>  create mode 100644 target/arm/hyp_gdbstub.c
>
> diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c
> new file mode 100644
> index 0000000000..22b2b7de7b
> --- /dev/null
> +++ b/target/arm/hyp_gdbstub.c
> @@ -0,0 +1,242 @@
> +#include "qemu/osdep.h"
> +#include "cpu.h"
> +#include "internals.h"
> +#include "exec/gdbstub.h"

New files must all start with the usual boilerplate
comment stating the license and copyright. Sorry I didn't
notice this in previous rounds of review.

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(which means "if you make this change in the next version of
the patchset, you should put this Reviewed-by: tag into the
commit message, so that reviewers know it's already been
reviewed".)

thanks
-- PMM