Re: [PATCH v3 03/14] migration: Initial support of fixed-ram feature for analyze-migration.py

[Daniel P . Berrangé]

On Fri, Oct 28, 2022 at 01:39:03PM +0300, Nikolay Borisov wrote:
> In order to allow analyze-migration.py script to work with migration
> streams that have the 'fixed-ram' capability set it's required to have
> access to the stream's configuration object. This commit enables this
> by making migration json writer part of MigrationState struct, allowing
> the configuration object be serialized to json.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  migration/migration.c        |  5 ++++
>  migration/migration.h        |  3 +++
>  migration/savevm.c           | 47 ++++++++++++++++++++++------------
>  scripts/analyze-migration.py | 49 +++++++++++++++++++++++++++++++++---
>  4 files changed, 85 insertions(+), 19 deletions(-)

This patch has a minor clash with a patch that's since merged
into git master

  commit e3bf5e68e2a97898f37834c47449101172ced123
  Author: David Hildenbrand <david@redhat.com>
  Date:   Tue Jan 17 12:22:43 2023 +0100

    migration/savevm: Prepare vmdesc json writer in qemu_savevm_state_setup()

so needs some adjustment, but nothing too major

The actual goal of this change makes sense to me.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|