Re: [PATCH v10 39/59] i386/xen: add monitor commands to test event injection

[Paul Durrant]

On 10/02/2023 15:05, David Woodhouse wrote:
> On Fri, 2023-02-10 at 14:54 +0000, Paul Durrant wrote:
> > Given that this patch only provides a command to inject an event on a
> > specific port, I think it's be useful to have the target field report
> > the type of a VIRQ. PV drivers often hook VIRQ_DEBUG for dumping debug
> > info, so knowing which of the VIRQ ports
>
> It's there in type_val, Wary of overengineering I hadn't actually
> translated it to strings but frankly if you don't know VIRQ_DEBUG is 1
> you don't deserve to play...

Ah, it's already in there... good. And indeed a number is all that's 
needed. In which case...

Reviewed-by: Paul Durrant <paul@xen.org>