Re: [PATCH v10 35/59] hw/xen: Implement EVTCHNOP_alloc_unbound

[Paul Durrant]

On 10/02/2023 14:17, David Woodhouse wrote:
> On Fri, 2023-02-10 at 14:13 +0000, Paul Durrant wrote:
> > > --- a/target/i386/kvm/xen-emu.c
> > > +++ b/target/i386/kvm/xen-emu.c
> > > @@ -918,6 +918,21 @@ static bool kvm_xen_hcall_evtchn_op(struct kvm_xen_exit 
> > > *exit, X86CPU *cpu,
> > >             err = xen_evtchn_send_op(&send);
> > >             break;
> > >         }
> > > +    case EVTCHNOP_alloc_unbound: {
> > > +        struct evtchn_alloc_unbound alloc;
> > > +
> > > +        qemu_build_assert(sizeof(alloc) == 8);
> >
> > Why?
>
> Because if that builds successfully for both x86_64 and i686 hosts, I
> was right that I didn't need to do any compat handling.

Ok. Fair enough.

Reviewed-by: Paul Durrant <paul@xen.org>