[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/4] multifd: Only sync once each full round of memory
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v4 3/4] multifd: Only sync once each full round of memory |
Date: |
Fri, 10 Feb 2023 07:29:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Juan Quintela <quintela@redhat.com> writes:
> We need to add a new flag to mean to sync at that point.
> Notice that we still synchronize at the end of setup and at the end of
> complete stages.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>
> Add missing qemu_fflush(), now it passes all tests always.
> ---
[...]
> diff --git a/migration/migration.c b/migration/migration.c
> index b2844d374f..9eb061319d 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -2710,8 +2710,6 @@ bool migrate_multifd_sync_after_each_section(void)
> {
> MigrationState *s = migrate_get_current();
>
> - return true;
> - // We will change this when code gets in.
> return
> s->enabled_capabilities[MIGRATION_CAPABILITY_MULTIFD_SYNC_AFTER_EACH_SECTION];
> }
Ah, nevermind.
[...]