[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 02/12] vfio/migration: Fix NULL pointer dereference bug
From: |
Avihai Horon |
Subject: |
[PATCH v10 02/12] vfio/migration: Fix NULL pointer dereference bug |
Date: |
Thu, 9 Feb 2023 21:20:33 +0200 |
As part of its error flow, vfio_vmstate_change() accesses
MigrationState->to_dst_file without any checks. This can cause a NULL
pointer dereference if the error flow is taken and
MigrationState->to_dst_file is not set.
For example, this can happen if VM is started or stopped not during
migration and vfio_vmstate_change() error flow is taken, as
MigrationState->to_dst_file is not set at that time.
Fix it by checking that MigrationState->to_dst_file is set before using
it.
Fixes: 02a7e71b1e5b ("vfio: Add VM state change handler to know state of VM")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
hw/vfio/migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index b3318f0f20..02db30fe8d 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -744,7 +744,9 @@ static void vfio_vmstate_change(void *opaque, bool running,
RunState state)
*/
error_report("%s: Failed to set device state 0x%x", vbasedev->name,
(migration->device_state & mask) | value);
- qemu_file_set_error(migrate_get_current()->to_dst_file, ret);
+ if (migrate_get_current()->to_dst_file) {
+ qemu_file_set_error(migrate_get_current()->to_dst_file, ret);
+ }
}
vbasedev->migration->vm_running = running;
trace_vfio_vmstate_change(vbasedev->name, running, RunState_str(state),
--
2.26.3
- [PATCH v10 00/12] vfio/migration: Implement VFIO migration protocol v2, Avihai Horon, 2023/02/09
- [PATCH v10 02/12] vfio/migration: Fix NULL pointer dereference bug,
Avihai Horon <=
- [PATCH v10 01/12] linux-headers: Update to v6.2-rc1, Avihai Horon, 2023/02/09
- [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support, Avihai Horon, 2023/02/09
- Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support, Juan Quintela, 2023/02/15
- Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support, Avihai Horon, 2023/02/15
- Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support, Juan Quintela, 2023/02/15
- Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support, Alex Williamson, 2023/02/15
- Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support, Jason Gunthorpe, 2023/02/15
- Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support, Alex Williamson, 2023/02/15
[PATCH v10 04/12] migration/qemu-file: Add qemu_file_get_to_fd(), Avihai Horon, 2023/02/09