Re: [PATCH v2] migration: I messed state_pending_exact/estimate

[Peter Maydell]

On Thu, 9 Feb 2023 at 15:23, Juan Quintela <quintela@redhat.com> wrote:
>
> I called the helper function from the wrong top level function.
>
> This code was introduced in:
>
> commit c8df4a7aeffcb46020f610526eea621fa5b0cd47
> Author: Juan Quintela <quintela@redhat.com>
> Date:   Mon Oct 3 02:00:03 2022 +0200
>
>     migration: Split save_live_pending() into state_pending_*
>
>     We split the function into to:
>
>     - state_pending_estimate: We estimate the remaining state size without
>       stopping the machine.
>
>     - state pending_exact: We calculate the exact amount of remaining
>       state.

Given that this commit has already gone out in a
release, it would be useful to describe in the commit
message what the consequences of the bug are, if any.

A Fixes: line would also record the commit being fixed
in a more easily processable way.

thanks
-- PMM