[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] migration: Remove spurious files
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] migration: Remove spurious files |
Date: |
Thu, 9 Feb 2023 12:17:23 +0000 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Feb 09, 2023 at 01:14:49PM +0100, Juan Quintela wrote:
> I introduced spurious files on my tree during a rebase:
>
> commit ebfc57871506b3fe36cc41f69ee3ad31a34afd63
> Author: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Date: Mon Oct 17 15:53:51 2022 +0800
>
> multifd: Fix flush of zero copy page send request
>
> Make IO channel flush call after the inflight request has been drained
> in multifd thread, or else we may missed to flush the inflight request.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> To make things worse, it appears like Zhenzhong is the one to blame.
>
> for(int i=0; i < 1000000; i++) {
> printf("I will not do rebases when I am tired\n");
> }
>
> Sorry, Juan.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> .../x86_64-quintela-devices.mak | 7 -
> .../x86_64-quintela2-devices.mak | 6 -
> migration/multifd.c.orig | 1274 -----------------
> 3 files changed, 1287 deletions(-)
> delete mode 100644 configs/devices/x86_64-softmmu/x86_64-quintela-devices.mak
> delete mode 100644
> configs/devices/x86_64-softmmu/x86_64-quintela2-devices.mak
> delete mode 100644 migration/multifd.c.orig
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|