[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/6] migration: moved hmp_split_at_commma() helper func to
From: |
Juan Quintela |
Subject: |
Re: [PATCH v3 1/6] migration: moved hmp_split_at_commma() helper func to qapi-util.c file |
Date: |
Thu, 09 Feb 2023 12:56:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Het Gala <het.gala@nutanix.com> wrote:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file. Give external linkage, as
> this function will be handy in coming commit for migration.
>
> Minor correction:
> g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",", -1)
>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
But I can't find this reviewed by emails neither on list or in my INBOX.
You can add this lines when someone answer with a mail that explicitely
contains them.
Later, Juan.
- [PATCH v3 0/6] migration: Modified 'migrate' QAPI command for migration, Het Gala, 2023/02/09
- [PATCH v3 1/6] migration: moved hmp_split_at_commma() helper func to qapi-util.c file, Het Gala, 2023/02/09
- [PATCH v3 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command, Het Gala, 2023/02/09
- [PATCH v3 3/6] migration: HMP side changes for modified 'migrate' QAPI design, Het Gala, 2023/02/09
- [PATCH v3 5/6] migration: Modified 'migrate-incoming' QAPI and HMP side changes on the destination interface., Het Gala, 2023/02/09
- [PATCH v3 4/6] migration: Avoid multiple parsing of uri in migration code flow, Het Gala, 2023/02/09
- [PATCH v3 6/6] migration: Established connection for listener sockets on the dest interface, Het Gala, 2023/02/09