Re: [PATCH v2 03/12] tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c

[Thomas Huth]

On 08/02/2023 20.46, Fabiano Rosas wrote:
> This test depends on the presence of the pcie-root-port device. Add a
> build time dependency.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   tests/qtest/meson.build | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index e97616d327..5c8b031ce0 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -73,7 +73,8 @@ qtests_i386 = \
>     (config_all_devices.has_key('CONFIG_ESP_PCI') ? ['am53c974-test'] : []) +   
>               \
>     (config_host.has_key('CONFIG_POSIX') and                                    
>               \
>      config_all_devices.has_key('CONFIG_ACPI_ERST') ? ['erst-test'] : []) +     
>               \
> -  (config_all_devices.has_key('CONFIG_VIRTIO_NET') and                         
>              \
> +  (config_all_devices.has_key('CONFIG_PCIE_PORT') and                          
>              \
> +   config_all_devices.has_key('CONFIG_VIRTIO_NET') and                         
>              \
>      config_all_devices.has_key('CONFIG_Q35') and                               
>               \
>      config_all_devices.has_key('CONFIG_VIRTIO_PCI') and                        
>               \
>      slirp.found() ? ['virtio-net-failover'] : []) +                            
>               \

Reviewed-by: Thomas Huth <thuth@redhat.com>