[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/6] multifd: Create property multifd-sync-after-each-sect
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 1/6] multifd: Create property multifd-sync-after-each-section |
Date: |
Wed, 8 Feb 2023 14:25:26 -0600 |
User-agent: |
NeoMutt/20220429 |
On Wed, Feb 08, 2023 at 02:30:05PM +0100, Juan Quintela wrote:
> We used to synchronize all channels at the end of each RAM section
> sent. That is not needed, so preparing to only synchronize once every
> full round in latests patches.
>
> Notice that we initialize the property as true. We will change the
> default when we introduce the new mechanism.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>
> Rename each-iteration to after-each-section
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> qapi/migration.json | 9 ++++++++-
> migration/migration.h | 1 +
> hw/core/machine.c | 1 +
> migration/migration.c | 15 +++++++++++++--
> 4 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index c84fa10e86..d712b082c8 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -478,6 +478,12 @@
> # should not affect the correctness of postcopy migration.
> # (since 7.1)
> #
> +# @multifd-sync-after-each-section: Synchronize channels after each
> +# section is sent. We used to do
> +# that on the past, but it is
s/on/in/
> +# suboptimal.
> +# (since 7.1)
Shouldn't this be 8.0 now?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v3 0/6] Eliminate multifd flush, Juan Quintela, 2023/02/08
- [PATCH v3 1/6] multifd: Create property multifd-sync-after-each-section, Juan Quintela, 2023/02/08
- Re: [PATCH v3 1/6] multifd: Create property multifd-sync-after-each-section,
Eric Blake <=
- [PATCH v3 2/6] multifd: Protect multifd_send_sync_main() calls, Juan Quintela, 2023/02/08
- [PATCH v3 3/6] migration: Simplify ram_find_and_save_block(), Juan Quintela, 2023/02/08
- [PATCH v3 4/6] migration: Make find_dirty_block() return a single parameter, Juan Quintela, 2023/02/08
- [PATCH v3 5/6] multifd: Only sync once each full round of memory, Juan Quintela, 2023/02/08
- [PATCH v3 6/6] ram: Document migration ram flags, Juan Quintela, 2023/02/08