Re: [RFC PATCH 4/4] ci, docker: update CentOS and OpenSUSE Python to non-EOL versions

[Daniel P . Berrangé]

On Tue, Jan 17, 2023 at 10:16:38AM +0100, Paolo Bonzini wrote:
> Python 3.6 is at end-of-life.  Update the libvirt-ci module to a
> version that supports overrides for targets and package mappings;
> this way, QEMU can use the newer versions provided by CentOS 8 (Python
> 3.8) and OpenSUSE 15.3 (Python 3.9).
> 
> One unexpected issue is that sphinx-rtd-theme does not want versions
> of docutils starting with 0.18.  For distro-installed packages we can
> assume that the packager knew this, but when installing from PyPI the
> package version needs to be constrained by hand.  In order to do this,
> add the docutils package explicitly to the qemu project file.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  .gitlab-ci.d/cirrus/freebsd-12.vars           |  2 +-
>  .gitlab-ci.d/cirrus/freebsd-13.vars           |  2 +-
>  .gitlab-ci.d/cirrus/macos-12.vars             |  2 +-
>  scripts/ci/setup/build-environment.yml        |  2 +-
>  tests/docker/dockerfiles/alpine.docker        |  1 +
>  tests/docker/dockerfiles/centos8.docker       | 23 +++---
>  .../dockerfiles/debian-amd64-cross.docker     |  1 +
>  tests/docker/dockerfiles/debian-amd64.docker  |  1 +
>  .../dockerfiles/debian-arm64-cross.docker     |  1 +
>  .../dockerfiles/debian-armel-cross.docker     |  1 +
>  .../dockerfiles/debian-armhf-cross.docker     |  1 +
>  .../dockerfiles/debian-mips64el-cross.docker  |  1 +
>  .../dockerfiles/debian-mipsel-cross.docker    |  1 +
>  .../dockerfiles/debian-ppc64el-cross.docker   |  1 +
>  .../dockerfiles/debian-s390x-cross.docker     |  1 +
>  .../dockerfiles/fedora-win32-cross.docker     |  1 +
>  .../dockerfiles/fedora-win64-cross.docker     |  1 +
>  tests/docker/dockerfiles/fedora.docker        |  1 +
>  tests/docker/dockerfiles/opensuse-leap.docker | 23 +++---
>  tests/docker/dockerfiles/ubuntu2004.docker    |  3 +-
>  tests/lcitool/mappings.yml                    | 80 +++++++++++++++++++
>  tests/lcitool/projects/qemu.yml               |  1 +
>  tests/lcitool/targets/centos-stream-8.yml     |  3 +
>  tests/lcitool/targets/opensuse-leap-153.yml   |  3 +
>  24 files changed, 131 insertions(+), 26 deletions(-)
>  create mode 100644 tests/lcitool/mappings.yml
>  create mode 100644 tests/lcitool/targets/centos-stream-8.yml
>  create mode 100644 tests/lcitool/targets/opensuse-leap-153.yml

Could you also update docs/devel/testing.rst where it talks
about lcitool, to give guidance about the local mappings/targets
overrides, vs the upstream mappings/targets usage. Most of the
time for new deps, we should continue to change the upstream
one, only using the local override where QEMU needs to diverge,
so that we maximise sharing.

The actual tests/ dir changes look ok to me

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|