Re: [PATCH 2/3] Replace `TARGET_TB_PCREL` with `CF_PCREL`

[Anton Johansson]

On 2/7/23 12:26, Philippe Mathieu-Daudé wrote:
> Possibly:
>
> #ifdef CONFIG_DEBUG_TCG
>
> > -            assert(!TARGET_TB_PCREL);
> > +            assert(!(tb_cflags(last_tb) & CF_PCREL));
> >               assert(cc->set_pc);
>
> #endif
>
> Or maybe clearer, use tcg_debug_assert()?
>
> >               cc->set_pc(cpu, tb_pc(last_tb));
> >           }
Thanks for the review!

tcg_debug_assert makes sense for the cflags check, but do we really want 
to disable
assert(cc->set_pc) in non-debug?

--
Anton Johansson,
rev.ng Labs Srl.