[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/13] vdpa: block migration if SVQ does not admit a feature
From: |
Eugenio Pérez |
Subject: |
[PATCH v2 12/13] vdpa: block migration if SVQ does not admit a feature |
Date: |
Wed, 8 Feb 2023 10:42:52 +0100 |
Next patches enable devices to be migrated even if vdpa netdev has not
been started with x-svq. However, not all devices are migratable, so we
need to block migration if we detect that.
Block migration if we detect the device expose a feature SVQ does not
know how to work with.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 9d30cf9b3c..13a86a2bb1 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -460,6 +460,15 @@ static int vhost_vdpa_init(struct vhost_dev *dev, void
*opaque, Error **errp)
if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_SUSPEND))) {
error_setg(&dev->migration_blocker,
"vhost-vdpa backend lacks VHOST_BACKEND_F_SUSPEND feature.");
+ } else {
+ /* We don't have dev->features yet */
+ uint64_t features;
+ ret = vhost_vdpa_get_dev_features(dev, &features);
+ if (unlikely(ret)) {
+ error_setg_errno(errp, -ret, "Could not get device features");
+ return ret;
+ }
+ vhost_svq_valid_features(features, &dev->migration_blocker);
}
}
--
2.31.1
- Re: [PATCH v2 09/13] vdpa net: block migration if the device has CVQ, (continued)
[PATCH v2 10/13] vdpa: block migration if device has unsupported features, Eugenio Pérez, 2023/02/08
[PATCH v2 11/13] vdpa: block migration if dev does not have _F_SUSPEND, Eugenio Pérez, 2023/02/08
[PATCH v2 12/13] vdpa: block migration if SVQ does not admit a feature,
Eugenio Pérez <=
[PATCH v2 13/13] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices, Eugenio Pérez, 2023/02/08
Re: [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration, Alvaro Karsz, 2023/02/08
Re: [PATCH v2 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration, Gautam Dawar, 2023/02/10