[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] migration: simplify blockers
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH V2] migration: simplify blockers |
|
Date: |
Tue, 7 Feb 2023 16:29:55 -0500 |
On Tue, Feb 07, 2023 at 04:17:34PM -0500, Steven Sistare wrote:
> >> + * *@reasonp is freed and set to NULL if failure is returned.
> >> + * On success, the caller no longer owns *@reasonp and must not free it.
> >
> > This statement reads weird. IMHO the caller still owns @reasonp, but if it
> > succeeded it should only free it with a migrate_del_blocker() later.
>
> How about:
> On success, the caller must not free @reasonp, except by calling
> migrate_del_blocker.
LGTM, thanks.
--
Peter Xu