qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/22] target/arm: Rewrite check_s2_mmu_setup


From: Richard Henderson
Subject: Re: [PATCH 02/22] target/arm: Rewrite check_s2_mmu_setup
Date: Tue, 7 Feb 2023 09:31:32 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 2/7/23 06:00, Peter Maydell wrote:
On Tue, 24 Jan 2023 at 00:01, Richard Henderson
<richard.henderson@linaro.org> wrote:

Integrate neighboring code from get_phys_addr_lpae which computed
starting level, as it is easier to validate when doing both at the
same time.  Mirror the checks at the start of AArch{64,32}.S2Walk,
especially S2InvalidESL and S2InconsistentSL.

This reverts 49ba115bb74, which was incorrect -- there is nothing
in the ARM pseudocode that depends on TxSZ, i.e. outputsize; the
pseudocode is consistent in referencing PAMax.

I'm having difficulty reviewing this one:
  * the latest version of the Arm ARM doesn't have the pseudocode
    functions you refer to, so it's difficult to cross-refer against
    the spec

DDI 0478 I.a certainly does have them (typo: S2InvalidSL not S2InvalidESL).


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]