Re: [PATCH] tests/qtest/netdev-socket: Raise connection timeout to 60 seconds

[Thomas Huth]

On 07/02/2023 17.51, Peter Maydell wrote:
> The netdev-socket test intermittently fails on our s390x CI runner:
>
> 633/659 ERROR:../tests/qtest/netdev-socket.c:197:test_stream_unix:
> assertion failed (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == 
> "st0: index=0,type=stream,unix:/tmp/netdev-socket.GZUG01/stream_unix\r\n")
> ERROR
> 633/659 qemu:qtest+qtest-xtensa / qtest-xtensa/netdev-socket
> ERROR           5.47s   killed by signal 6 SIGABRT
>
> This may just be because when the machine is under heavy load
> running the CI tests it hits the timeout before the QEMU
> under test has started to the point of being able to respond
> to HMP queries.
>
> Bump the timeout to 60 seconds to see if the intermittent
> goes away.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   tests/qtest/netdev-socket.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
> index 6ba256e1730..1d98dca821f 100644
> --- a/tests/qtest/netdev-socket.c
> +++ b/tests/qtest/netdev-socket.c
> @@ -12,7 +12,7 @@
>   #include "../unit/socket-helpers.h"
>   #include "libqtest.h"
>   
> -#define CONNECTION_TIMEOUT    5
> +#define CONNECTION_TIMEOUT    60

Acked-by: Thomas Huth <thuth@redhat.com>

Feel free to apply directly as a CI fix, I don't have any pull request 
planned in the next days.