Re: [PULL 00/20] Header cleanup patches for 2023-02-06

[Peter Maydell]

On Tue, 7 Feb 2023 at 06:45, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit 6661b8c7fe3f8b5687d2d90f7b4f3f23d70e3e8b:
>
>   Merge tag 'pull-ppc-20230205' of https://gitlab.com/danielhb/qemu into 
> staging (2023-02-05 16:49:09 +0000)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/armbru.git tags/pull-include-2023-02-06
>
> for you to fetch changes up to e74285cc0d1d517271531c4103d8bbabe1bdad7d:
>
>   Drop duplicate #include (2023-02-06 16:40:33 +0100)
>
> ----------------------------------------------------------------
> Header cleanup patches for 2023-02-06
>
> ----------------------------------------------------------------
> Markus Armbruster (20):
>       scripts/clean-includes: Fully skip / ignore files
>       scripts/clean-includes: Don't claim duplicate headers found when not
>       scripts/clean-includes: Skip symbolic links
>       scripts/clean-includes: Improve --git commit message
>       bsd-user: Clean up includes
>       crypto: Clean up includes
>       hw/cxl: Clean up includes
>       hw/input: Clean up includes
>       hw/tricore: Clean up includes
>       qga: Clean up includes
>       migration: Clean up includes
>       net: Clean up includes
>       target/hexagon: Clean up includes
>       riscv: Clean up includes
>       block: Clean up includes
>       accel: Clean up includes
>       Fix non-first inclusions of qemu/osdep.h
>       Don't include headers already included by qemu/osdep.h
>       9p: Drop superfluous include of linux/limits.h
>       Drop duplicate #include

Failed to build, alpine:

https://gitlab.com/qemu-project/qemu/-/jobs/3729904042

../hw/9pfs/9p.c: In function 'v9fs_xattrcreate':
../hw/9pfs/9p.c:3968:27: error: 'XATTR_SIZE_MAX' undeclared (first use
in this function); did you mean 'P9_XATTR_SIZE_MAX'?
3968 | #define P9_XATTR_SIZE_MAX XATTR_SIZE_MAX
| ^~~~~~~~~~~~~~
../hw/9pfs/9p.c:4016:16: note: in expansion of macro 'P9_XATTR_SIZE_MAX'
4016 | if (size > P9_XATTR_SIZE_MAX) {
| ^~~~~~~~~~~~~~~~~
../hw/9pfs/9p.c:3968:27: note: each undeclared identifier is reported
only once for each function it appears in
3968 | #define P9_XATTR_SIZE_MAX XATTR_SIZE_MAX
| ^~~~~~~~~~~~~~
../hw/9pfs/9p.c:4016:16: note: in expansion of macro 'P9_XATTR_SIZE_MAX'
4016 | if (size > P9_XATTR_SIZE_MAX) {
| ^~~~~~~~~~~~~~~~~

Your commit "9p: Drop superfluous include of linux/limits.h"
inadvertently broke this -- on glibc other headers drag
in limits.h to define XATTR_SIZE_MAX, but on musl they
don't and so the include is required.

thanks
-- PMM