qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/4] qemu-io: use BdrvRequestFlags instead of int


From: Hanna Czenczek
Subject: Re: [PATCH v3 2/4] qemu-io: use BdrvRequestFlags instead of int
Date: Tue, 7 Feb 2023 12:47:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 01.02.23 16:27, Stefan Hajnoczi wrote:
The block layer APIs use BdrvRequestFlags while qemu-io code uses int.
Although the code compiles and runs fine, BdrvRequestFlags is clearer
because it differentiates between other types of flags like bdrv_open()
flags.

This is purely refactoring.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
  qemu-io-cmds.c | 15 ++++++++-------
  1 file changed, 8 insertions(+), 7 deletions(-)

With a rebase on264dcbb2b1e5b66d7a5b08662b200c2b315dce0f:

Reviewed-by: Hanna Czenczek <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]