[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v4 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface |
Date: |
Tue, 7 Feb 2023 07:51:08 +0100 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 |
On 7/2/23 00:24, Hao Wu wrote:
Hi,
It seems like this patch set is reviewed but never merged. Who should
take this patch set? What are our next steps for them?
Having some interest in interaction with emulated analog world,
I could have an overall look at hw/sensor/. Co-maintainers welcomed!
On Mon, Jan 31, 2022 at 2:29 PM Patrick Venture <venture@google.com
<mailto:venture@google.com>> wrote:
From: Hao Wu <wuhaotsh@google.com <mailto:wuhaotsh@google.com>>
SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible
interface that reports AMD SoC's Ttcl (normalized temperature),
and resembles a typical 8-pin remote temperature sensor's I2C interface
to BMC.
This patch implements a basic AMD SB-TSI sensor that is
compatible with the open-source data sheet from AMD and Linux
kernel driver.
Reference:
Linux kernel driver:
https://lkml.org/lkml/2020/12/11/968
<https://lkml.org/lkml/2020/12/11/968>
Register Map:
https://developer.amd.com/wp-content/resources/56255_3_03.PDF
<https://developer.amd.com/wp-content/resources/56255_3_03.PDF>
(Chapter 6)
Signed-off-by: Hao Wu <wuhaotsh@google.com <mailto:wuhaotsh@google.com>>
Signed-off-by: Patrick Venture <venture@google.com
<mailto:venture@google.com>>
Reviewed-by: Doug Evans <dje@google.com <mailto:dje@google.com>>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org
<mailto:f4bug@amsat.org>>
Acked-by: Corey Minyard <cminyard@mvista.com
<mailto:cminyard@mvista.com>>
---
meson.build | 1 +
hw/sensor/trace.h | 1 +
include/hw/sensor/sbtsi.h | 45 +++++
hw/sensor/tmp_sbtsi.c | 369 ++++++++++++++++++++++++++++++++++++++
hw/sensor/Kconfig | 4 +
hw/sensor/meson.build | 1 +
hw/sensor/trace-events | 5 +
7 files changed, 426 insertions(+)
create mode 100644 hw/sensor/trace.h
create mode 100644 include/hw/sensor/sbtsi.h
create mode 100644 hw/sensor/tmp_sbtsi.c
create mode 100644 hw/sensor/trace-events