[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] tests/qtest: Do not run lsi53c895a test if device is n
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH 02/12] tests/qtest: Do not run lsi53c895a test if device is not present |
Date: |
Mon, 06 Feb 2023 14:46:05 -0300 |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 6/2/23 16:04, Fabiano Rosas wrote:
>> The tests are built once for all the targets, so as long as one QEMU
>> binary is built with CONFIG_LSI_SCSI_PCI=y, this test will
>> run. However some binaries might not include the device. So check this
>> again in runtime.
>>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>> tests/qtest/fuzz-lsi53c895a-test.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/tests/qtest/fuzz-lsi53c895a-test.c
>> b/tests/qtest/fuzz-lsi53c895a-test.c
>> index 392a7ae7ed..a9254b455d 100644
>> --- a/tests/qtest/fuzz-lsi53c895a-test.c
>> +++ b/tests/qtest/fuzz-lsi53c895a-test.c
>> @@ -112,6 +112,10 @@ static void test_lsi_do_dma_empty_queue(void)
>>
>> int main(int argc, char **argv)
>> {
>> + if (!qtest_has_device("lsi53c895a")) {
>> + return 0;
>> + }
>
> Shouldn't we update Kconfig to now add the test unconditionally?
> Squashing:
I think we'd still want to not build this test if nothing selected
CONFIG_LSI_SCSI_PCI.
[PATCH 03/12] tests/qtest: Add dependence on PCIE_ROOT for virtio-net-failover.c, Fabiano Rosas, 2023/02/06
[PATCH 04/12] tests/qtest: Skip virtio-serial-console tests if device not present, Fabiano Rosas, 2023/02/06