qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 11/12] tests/qtest: bios-tables-test: Skip if missing configs


From: Fabiano Rosas
Subject: [PATCH 11/12] tests/qtest: bios-tables-test: Skip if missing configs
Date: Mon, 6 Feb 2023 12:04:15 -0300

If we build with --without-default-devices, CONFIG_HPET and
CONFIG_PARALLEL are set to N, which makes the respective devices go
missing from acpi tables.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
I currently don't see a way of allowing the tests to pass in the
absence of these two configs. As far as I understand, we would need to
have one set of expected table files (tests/data/acpi) for each
combination of machine vs. possible CONFIG that can be toggled.

Any ideas?
---
 tests/qtest/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index a930706a43..2829eda2c9 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -78,7 +78,9 @@ qtests_i386 = \
    config_all_devices.has_key('CONFIG_Q35') and                                
             \
    config_all_devices.has_key('CONFIG_VIRTIO_PCI') and                         
             \
    slirp.found() ? ['virtio-net-failover'] : []) +                             
             \
-  (unpack_edk2_blobs ? ['bios-tables-test'] : []) +                            
             \
+  (unpack_edk2_blobs and                                                       
             \
+   config_all_devices.has_key('CONFIG_HPET') and                               
             \
+   config_all_devices.has_key('CONFIG_PARALLEL') ? ['bios-tables-test'] : []) 
+             \
   qtests_pci +                                                                 
             \
   qtests_cxl +                                                                 
             \
   ['fdc-test',
-- 
2.35.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]