Re: [PATCH v15 05/11] s390x/cpu topology: resetting the Topology-Change-Report

[Pierre Morel]

On 2/6/23 12:05, Thomas Huth wrote:
> On 01/02/2023 14.20, Pierre Morel wrote:
> > During a subsystem reset the Topology-Change-Report is cleared
> > by the machine.
> > Let's ask KVM to clear the Modified Topology Change Report (MTCR)
> > bit of the SCA in the case of a subsystem reset.
> >
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > ---
> ...
> > diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c
> > index a80a1ebf22..cf63f3dd01 100644
> > --- a/hw/s390x/cpu-topology.c
> > +++ b/hw/s390x/cpu-topology.c
> > @@ -85,6 +85,18 @@ static void s390_topology_init(MachineState *ms)
> >       QTAILQ_INSERT_HEAD(&s390_topology.list, entry, next);
> >   }
> > +/**
> > + * s390_topology_reset:
> > + *
> > + * Generic reset for CPU topology, calls s390_topology_reset()
> > + * s390_topology_reset() to reset the kernel Modified Topology
>
> Duplicated s390_topology_reset() in the comment.

right, thx.

> > + * change record.
> > + */
> > +void s390_topology_reset(void)
> > +{
> > +    s390_cpu_topology_reset();
> > +}
>
> With the nit fixed:
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks!

Regards,
Pierre

--
Pierre Morel
IBM Lab Boeblingen