Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI

[Philippe Mathieu-Daudé]

On 6/2/23 11:54, Andrea Bolognani wrote:
> On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L wrote:
> > +    object_class_property_add(oc, "acpi", "OnOffAuto",
> > +                              virt_get_acpi, virt_set_acpi,
> > +                              NULL, NULL);
> > +    object_class_property_set_description(oc, "acpi",
> > +                                          "Enable ACPI");
>
> The way this works on other architectures (x86_64, aarch64) is that
> you get ACPI by default and can use -no-acpi to disable it if
> desired. Can we have the same on RISC-V, for consistency?

-no-acpi rather seems a x86-specific hack for the ISA PC machine, and
has a high maintenance cost / burden.

If hardware provides ACPI support, QEMU should expose it to the guest.

Actually, what is the value added by '-no-acpi'?