Re: [PATCH 3/3] hw/mips: Add MIPS virt board

[Philippe Mathieu-Daudé]

Hi Jiaxun,

On 2/2/23 14:21, Jiaxun Yang wrote:
> MIPS virt board is design to utilize existing VirtIO infrastures
> but also comptitable with MIPS's existing internal simulation tools.
>
> It includes virtio-mmio, pcie gpex, flash rom, fw_cfg, goldfish-rtc,
> and optional goldfish_pic in case MIPS GIC is not present.

Is it worth using the CPS/GIC? Can't we using the goldfish PIC
regardless CPS availability? Did you run performance comparison?

> It should be able to cooperate with any MIPS CPU cores.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> v1:
>   - Rename to virt board
>   - Convert BIOS flash to ROM
>   - Cleanups
> ---
>   MAINTAINERS                             |    7 +
>   configs/devices/mips-softmmu/common.mak |    1 +
>   docs/system/target-mips.rst             |   24 +
>   hw/mips/Kconfig                         |   18 +
>   hw/mips/meson.build                     |    1 +
>   hw/mips/virt.c                          | 1015 +++++++++++++++++++++++
>   6 files changed, 1066 insertions(+)
>   create mode 100644 hw/mips/virt.c