qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 7/9] hw/pci-host/pam: Make init_pam() usage more readable


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 7/9] hw/pci-host/pam: Make init_pam() usage more readable
Date: Sun, 5 Feb 2023 12:16:50 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 4/2/23 16:10, Bernhard Beschow wrote:
Unlike pam_update() which takes the subject -- PAMMemoryRegion -- as
first argument, init_pam() takes it as fifth (!) argument. This makes it
quite hard to figure out what an init_pam() invocation actually
initializes. By moving the subject to the front this should become
clearer.

While at it, lower the DeviceState parameter to Object, also
communicating more clearly that this parameter is just the owner rather
than some (heavy?) dependency.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
  include/hw/pci-host/pam.h |  5 +++--
  hw/pci-host/i440fx.c      | 10 +++++-----
  hw/pci-host/pam.c         | 12 ++++++------
  hw/pci-host/q35.c         |  8 ++++----
  4 files changed, 18 insertions(+), 17 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]