qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/4] qapi: update pylint configuration


From: Markus Armbruster
Subject: Re: [PATCH v4 4/4] qapi: update pylint configuration
Date: Sat, 04 Feb 2023 12:34:54 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

John Snow <jsnow@redhat.com> writes:

> Newer versions of pylint disable the "no-self-use" message by
> default. Older versions don't, though. If we leave the suppressions in,
> pylint yelps about useless options. Just tell pylint to shush.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  scripts/qapi/pylintrc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
> index a7246282030..90546df5345 100644
> --- a/scripts/qapi/pylintrc
> +++ b/scripts/qapi/pylintrc
> @@ -23,6 +23,7 @@ disable=fixme,
>          too-many-statements,
>          too-many-instance-attributes,
>          consider-using-f-string,
> +        useless-option-value,
>  
>  [REPORTS]

Pylint docs[*] explains this is "used when a value for an option that is
now deleted from pylint is encountered."  Switching that off makes sense
when you have to deal with a range of versions.  Occasional garbage
collection of old options is advised :)

Reviewed-by: Markus Armbruster <armbru@redhat.com>


[*] 
https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/useless-option-value.html




reply via email to

[Prev in Thread] Current Thread [Next in Thread]