[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/13] vdpa: rewind at get_base, not set_base
From: |
Eugenio Pérez |
Subject: |
[PATCH 05/13] vdpa: rewind at get_base, not set_base |
Date: |
Fri, 3 Feb 2023 20:11:34 +0100 |
At this moment it is only possible to migrate to a vdpa device running
with x-svq=on. As a protective measure, the rewind of the inflight
descriptors was done at the destination. That way if the source sent a
virtqueue with inuse descriptors they are always discarded.
Since this series allows to migrate also to passthrough devices with no
SVQ, the right thing to do is to rewind at the source so the base of
vrings are correct.
Support for inflight descriptors may be added in the future.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 6d20d70601..6385c16a55 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1211,18 +1211,7 @@ static int vhost_vdpa_set_vring_base(struct vhost_dev
*dev,
struct vhost_vring_state *ring)
{
struct vhost_vdpa *v = dev->opaque;
- VirtQueue *vq = virtio_get_queue(dev->vdev, ring->index);
- /*
- * vhost-vdpa devices does not support in-flight requests. Set all of them
- * as available.
- *
- * TODO: This is ok for networking, but other kinds of devices might
- * have problems with these retransmissions.
- */
- while (virtqueue_rewind(vq, 1)) {
- continue;
- }
if (v->shadow_vqs_enabled) {
/*
* Device vring base was set at device start. SVQ base is handled by
@@ -1241,6 +1230,19 @@ static int vhost_vdpa_get_vring_base(struct vhost_dev
*dev,
int ret;
if (v->shadow_vqs_enabled) {
+ VirtQueue *vq = virtio_get_queue(dev->vdev, ring->index);
+
+ /*
+ * vhost-vdpa devices does not support in-flight requests. Set all of
+ * them as available.
+ *
+ * TODO: This is ok for networking, but other kinds of devices might
+ * have problems with these retransmissions.
+ */
+ while (virtqueue_rewind(vq, 1)) {
+ continue;
+ }
+
ring->num = virtio_queue_get_last_avail_idx(dev->vdev, ring->index);
return 0;
}
--
2.31.1
- [PATCH 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration, Eugenio Pérez, 2023/02/03
- [PATCH 05/13] vdpa: rewind at get_base, not set_base,
Eugenio Pérez <=
- [PATCH 03/13] vdpa: add vhost_vdpa_suspend, Eugenio Pérez, 2023/02/03
- [PATCH 06/13] vdpa net: allow VHOST_F_LOG_ALL, Eugenio Pérez, 2023/02/03
- [PATCH 07/13] vdpa: add vdpa net migration state notifier, Eugenio Pérez, 2023/02/03
- [PATCH 02/13] vdpa: Negotiate _F_SUSPEND feature, Eugenio Pérez, 2023/02/03
- [PATCH 04/13] vdpa: move vhost reset after get vring base, Eugenio Pérez, 2023/02/03
- [PATCH 08/13] vdpa: disable RAM block discard only for the first device, Eugenio Pérez, 2023/02/03
- [PATCH 09/13] vdpa net: block migration if the device has CVQ, Eugenio Pérez, 2023/02/03
- [PATCH 01/13] vdpa net: move iova tree creation from init to start, Eugenio Pérez, 2023/02/03
- [PATCH 10/13] vdpa: block migration if device has unsupported features, Eugenio Pérez, 2023/02/03
- [PATCH 11/13] vdpa: block migration if dev does not have _F_SUSPEND, Eugenio Pérez, 2023/02/03