[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 04/15] hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 04/15] hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref() |
Date: |
Fri, 3 Feb 2023 15:55:25 +0100 |
(See commits dc3edf8d8a "Convert to qdev_unrealize() manually"
and 981c3dcd94 "Convert to qdev_unrealize() with Coccinelle").
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/pci/pcie_sriov.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c
index 93b0624599..0b6101302b 100644
--- a/hw/pci/pcie_sriov.c
+++ b/hw/pci/pcie_sriov.c
@@ -204,11 +204,10 @@ static void unregister_vfs(PCIDevice *dev)
for (i = 0; i < num_vfs; i++) {
Error *errp = NULL;
PCIDevice *vf = dev->exp.sriov_pf.vf[i];
- object_property_set_bool(OBJECT(vf), "realized", false, &errp);
- if (errp) {
+
+ if (!qdev_unrealize_and_unref(DEVICE(vf), &errp)) {
warn_reportf_err(errp, "Failed to unplug: ");
}
- object_unparent(OBJECT(vf));
}
g_free(dev->exp.sriov_pf.vf);
dev->exp.sriov_pf.vf = NULL;
--
2.38.1
- [PATCH v2 00/15] hw: Use QOM alias properties and few QOM/QDev cleanups, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 01/15] hw/pci/pcie_sriov: Replace fprintf(error_pretty) -> warn_reportf_err(), Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 02/15] hw/qdev: Introduce qdev_unrealize_and_unref(), Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 03/15] linux-user/syscall: Do not open-code qdev_unrealize_and_unref(), Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 04/15] hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref(),
Philippe Mathieu-Daudé <=
- [PATCH v2 05/15] hw/i386/sgx: Do not open-code qdev_realize_and_unref(), Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 06/15] hw/ppc/sam460ex: Correctly set MAL properties, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 07/15] hw/arm/nrf51: Alias 'flash-size' QOM property in SoC object, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 08/15] hw/arm/fsl-imx: Alias 'phy-num' QOM property in SoC object, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 09/15] hw/usb/hcd-ohci: Include missing 'sysbus.h' header, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 10/15] hw/display/sm501: Embed OHCI QOM child in chipset, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 11/15] hw/display/sm501: Alias 'dma-offset' QOM property in chipset object, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 12/15] hw/display/sm501: Unify common QOM properties, Philippe Mathieu-Daudé, 2023/02/03