[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 12/12] parallels: Incorrect condition in out-of-image check
From: |
Alexander Ivanov |
Subject: |
[PATCH v10 12/12] parallels: Incorrect condition in out-of-image check |
Date: |
Fri, 3 Feb 2023 10:18:54 +0100 |
All the offsets in the BAT must be lower than the file size.
Fix the check condition for correct check.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
block/parallels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 61e7e4010d..8ff7d55c96 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -455,7 +455,7 @@ static int parallels_check_outside_image(BlockDriverState
*bs,
high_off = 0;
for (i = 0; i < s->bat_size; i++) {
off = bat2sect(s, i) << BDRV_SECTOR_BITS;
- if (off > size) {
+ if (off + s->cluster_size > size) {
fprintf(stderr, "%s cluster %u is outside image\n",
fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
res->corruptions++;
--
2.34.1
- Re: [PATCH v10 01/12] parallels: Out of image offset in BAT leads to image inflation, (continued)
- [PATCH v10 02/12] parallels: Fix high_off calculation in parallels_co_check(), Alexander Ivanov, 2023/02/03
- [PATCH v10 03/12] parallels: Fix image_end_offset and data_end after out-of-image check, Alexander Ivanov, 2023/02/03
- [PATCH v10 06/12] parallels: Move check of unclean image to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 04/12] parallels: create parallels_set_bat_entry_helper() to assign BAT value, Alexander Ivanov, 2023/02/03
- [PATCH v10 05/12] parallels: Use generic infrastructure for BAT writing in parallels_co_check(), Alexander Ivanov, 2023/02/03
- [PATCH v10 07/12] parallels: Move check of cluster outside image to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 09/12] parallels: Move check of leaks to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 10/12] parallels: Move statistic collection to a separate function, Alexander Ivanov, 2023/02/03
- [PATCH v10 12/12] parallels: Incorrect condition in out-of-image check,
Alexander Ivanov <=
- [PATCH v10 11/12] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD, Alexander Ivanov, 2023/02/03
- [PATCH v10 08/12] parallels: Fix statistics calculation, Alexander Ivanov, 2023/02/03