[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/35] hmp: Drop redundant argument check from add_completion_opti
From: |
Markus Armbruster |
Subject: |
[PULL 08/35] hmp: Drop redundant argument check from add_completion_option() |
Date: |
Fri, 3 Feb 2023 09:45:22 +0100 |
No need to check for null arguments, no caller passes them.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230124121946.1139465-6-armbru@redhat.com>
---
monitor/misc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/monitor/misc.c b/monitor/misc.c
index c18a713d9c..d58a81c452 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -1353,9 +1353,6 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const
char *name)
static void add_completion_option(ReadLineState *rs, const char *str,
const char *option)
{
- if (!str || !option) {
- return;
- }
if (!strncmp(option, str, strlen(str))) {
readline_add_completion(rs, option);
}
--
2.39.0
- [PULL 02/35] MAINTAINERS: Cover include/sysemu/accel-blocker.h, (continued)
- [PULL 02/35] MAINTAINERS: Cover include/sysemu/accel-blocker.h, Markus Armbruster, 2023/02/03
- [PULL 11/35] trace: Move HMP commands from monitor/ to trace/, Markus Armbruster, 2023/02/03
- [PULL 12/35] machine: Move QMP commands from monitor/ to hw/core/, Markus Armbruster, 2023/02/03
- [PULL 03/35] MAINTAINERS: Cover tpm.c again, Markus Armbruster, 2023/02/03
- [PULL 24/35] runstate: Move HMP commands from monitor/ to softmmu/, Markus Armbruster, 2023/02/03
- [PULL 15/35] block: Factor out hmp_change_medium(), and move to block/monitor/, Markus Armbruster, 2023/02/03
- [PULL 30/35] monitor: Move monitor_putc() next to monitor_puts & external linkage, Markus Armbruster, 2023/02/03
- [PULL 18/35] net: Move HMP commands from monitor to net/, Markus Armbruster, 2023/02/03
- [PULL 28/35] qdev: Move HMP command completion from monitor to softmmu/, Markus Armbruster, 2023/02/03
- [PULL 35/35] monitor: Rename misc.c to hmp-target.c, Markus Armbruster, 2023/02/03
- [PULL 08/35] hmp: Drop redundant argument check from add_completion_option(),
Markus Armbruster <=
- [PULL 31/35] monitor: Move target-dependent HMP commands to hmp-cmds-target.c, Markus Armbruster, 2023/02/03
- [PULL 01/35] MAINTAINERS: Cover userfaultfd, Markus Armbruster, 2023/02/03
- [PULL 33/35] monitor: Move remaining QMP stuff from misc.c to qmp-cmds.c, Markus Armbruster, 2023/02/03
- [PULL 25/35] stats: Move QMP commands from monitor/ to stats/, Markus Armbruster, 2023/02/03
- [PULL 34/35] monitor: Loosen coupling between misc.c and monitor.c slightly, Markus Armbruster, 2023/02/03
- [PULL 20/35] migration: Move HMP commands from monitor/ to migration/, Markus Armbruster, 2023/02/03
- [PULL 05/35] audio: Move HMP commands from monitor/ to audio/, Markus Armbruster, 2023/02/03
- [PULL 26/35] stats: Move HMP commands from monitor/ to stats/, Markus Armbruster, 2023/02/03
- [PULL 23/35] tpm: Move HMP commands from monitor/ to softmmu/, Markus Armbruster, 2023/02/03
- [PULL 17/35] hmp: Rewrite strlist_from_comma_list() as hmp_split_at_comma(), Markus Armbruster, 2023/02/03