[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/39] target/riscv: expose zvkb cpu property
|
From: |
Philipp Tomsich |
|
Subject: |
Re: [PATCH 10/39] target/riscv: expose zvkb cpu property |
|
Date: |
Thu, 2 Feb 2023 15:24:44 +0100 |
On Thu, 2 Feb 2023 at 15:23, Philipp Tomsich <philipp.tomsich@vrull.eu> wrote:
>
> On Thu, 2 Feb 2023 at 13:42, Lawrence Hunter
> <lawrence.hunter@codethink.co.uk> wrote:
> >
> > From: Nazar Kazakov <nazar.kazakov@codethink.co.uk>
> >
> > Signed-off-by: Nazar Kazakov <nazar.kazakov@codethink.co.uk>
>
> You might want to squash this onto the patch that first introduces the
> property.
>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
>
> > ---
> > target/riscv/cpu.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> > index bd34119c75..35790befc0 100644
> > --- a/target/riscv/cpu.c
> > +++ b/target/riscv/cpu.c
> > @@ -1082,6 +1082,8 @@ static Property riscv_cpu_extensions[] = {
> >
> > DEFINE_PROP_BOOL("zmmul", RISCVCPU, cfg.ext_zmmul, false),
> >
> > + DEFINE_PROP_BOOL("zvkb", RISCVCPU, cfg.ext_zvkb, false),
I missed this earlier: the extension is not ratified. So please: "x-zvkb".
And it needs to go under the comment:
/* These are experimental so mark with 'x-' */
> > +
> > /* Vendor-specific custom extensions */
> > DEFINE_PROP_BOOL("xventanacondops", RISCVCPU, cfg.ext_XVentanaCondOps,
> > false),
> >
> > --
> > 2.39.1
> >
- [PATCH 33/39] target/riscv: Add vghmac.vv decoding, translation and execution support, (continued)
- [PATCH 33/39] target/riscv: Add vghmac.vv decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 16/39] target/riscv: Add vaesdm.vv decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 22/39] target/riscv: Add vaeskf2.vi decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 20/39] target/riscv: Add vaesem.vs decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 03/39] target/riscv: Add vclmul.vx decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 36/39] crypto: Add SM4 constant parameter CK., Lawrence Hunter, 2023/02/02
- [PATCH 37/39] target/riscv: Add zvksed cfg property, Lawrence Hunter, 2023/02/02
- [PATCH 10/39] target/riscv: expose zvkb cpu property, Lawrence Hunter, 2023/02/02
- [PATCH 09/39] target/riscv: Add vandn.[vv, vx, vi] decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 02/39] target/riscv: Add vclmul.vv decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 13/39] target/riscv: Add vaesef.vs decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 14/39] target/riscv: Add vaesdf.vv decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 18/39] target/riscv: Add vaesz.vs decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 19/39] target/riscv: Add vaesem.vv decoding, translation and execution support, Lawrence Hunter, 2023/02/02
- [PATCH 24/39] target/riscv: add zvknh cpu properties, Lawrence Hunter, 2023/02/02
- [PATCH 39/39] target/riscv: Expose Zvksed property, Lawrence Hunter, 2023/02/02