[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit messag
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message |
|
Date: |
Thu, 02 Feb 2023 11:54:54 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote:
> It's less terse. Fine with me. The mix of passive and active voice
> feels a bit awkward, though. Another try:
>
> All .c should include qemu/osdep.h first. This script performs three
> related cleanups:
>
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c already includes
> it. Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
> Drop these, too.
Perfect, thanks.
Reviewed-by: Juan Quintela <quintela@redhat.com>
or whatever you want it O:-)