[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 01/18] machine: Fix comment of machine_parse_smp_config()
From: |
Zhao Liu |
Subject: |
[PATCH 01/18] machine: Fix comment of machine_parse_smp_config() |
Date: |
Thu, 2 Feb 2023 17:49:12 +0800 |
From: Zhao Liu <zhao1.liu@intel.com>
Now smp supports dies and clusters, so add description about these 2
levels in the comment of machine_parse_smp_config().
Fixes: 864c3b5 (hw/core/machine: Introduce CPU cluster topology support)
Suggested-by: Robert Hoo <robert.hu@linux.intel.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
hw/core/machine-smp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
index c3dab007dadc..3fd9e641efde 100644
--- a/hw/core/machine-smp.c
+++ b/hw/core/machine-smp.c
@@ -51,8 +51,8 @@ static char *cpu_hierarchy_to_string(MachineState *ms)
* machine_parse_smp_config: Generic function used to parse the given
* SMP configuration
*
- * Any missing parameter in "cpus/maxcpus/sockets/cores/threads" will be
- * automatically computed based on the provided ones.
+ * Any missing parameter in "cpus/maxcpus/sockets/dies/clusters/cores/threads"
+ * will be automatically computed based on the provided ones.
*
* In the calculation of omitted sockets/cores/threads: we prefer sockets
* over cores over threads before 6.2, while preferring cores over sockets
@@ -66,7 +66,8 @@ static char *cpu_hierarchy_to_string(MachineState *ms)
*
* For compatibility, apart from the parameters that will be computed, newly
* introduced topology members which are likely to be target specific should
- * be directly set as 1 if they are omitted (e.g. dies for PC since 4.1).
+ * be directly set as 1 if they are omitted (e.g. dies for PC since v4.1 and
+ * clusters for arm since v7.0).
*/
void machine_parse_smp_config(MachineState *ms,
const SMPConfiguration *config, Error **errp)
--
2.34.1
- [PATCH 00/18] Support smp.clusters for x86, Zhao Liu, 2023/02/02
- [PATCH 01/18] machine: Fix comment of machine_parse_smp_config(),
Zhao Liu <=
- [PATCH 03/18] softmmu: Fix CPUSTATE.nr_cores' calculation, Zhao Liu, 2023/02/02
- [PATCH 02/18] tests: Rename test-x86-cpuid.c to test-x86-apicid.c, Zhao Liu, 2023/02/02
- [PATCH 04/18] i386/cpu: Fix number of addressable IDs in CPUID.04H, Zhao Liu, 2023/02/02
- [PATCH 05/18] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid(), Zhao Liu, 2023/02/02
- [PATCH 06/18] i386: Introduce module-level cpu topology to CPUX86State, Zhao Liu, 2023/02/02
- [PATCH 07/18] i386: Support modules_per_die in X86CPUTopoInfo, Zhao Liu, 2023/02/02
- [PATCH 09/18] i386: Fix comment style in topology.h, Zhao Liu, 2023/02/02
- [PATCH 10/18] i386: Update APIC ID parsing rule to support module level, Zhao Liu, 2023/02/02
- [PATCH 08/18] i386: Support module_id in X86CPUTopoIDs, Zhao Liu, 2023/02/02
- [PATCH 11/18] i386/cpu: Introduce cluster-id to X86CPU, Zhao Liu, 2023/02/02