Re: [PATCH v1 14/24] vfio-user: get and set IRQs

[John Johnson]

> On Dec 13, 2022, at 8:39 AM, Cédric Le Goater <clg@redhat.com> wrote:
> 
> On 11/9/22 00:13, John Johnson wrote:
>> 
>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
>> index 7abe44e..be39a4e 100644
>> --- a/hw/vfio/pci.c
>> +++ b/hw/vfio/pci.c
>> @@ -713,7 +713,8 @@ retry:
>>      ret = vfio_enable_vectors(vdev, false);
>>      if (ret) {
>>          if (ret < 0) {
>> -            error_report("vfio: Error: Failed to setup MSI fds: %m");
>> +            error_report("vfio: Error: Failed to setup MSI fds: %s",
>> +                         strerror(-ret));
> 
> This change belongs to another patch.
> 

        This is the patch where errno may not be set because
vfio_enable_vectors() didn’t make a syscall.

                                                        JJ