[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 15/36] tcg: Add guest load/store primitives for TCGv_i128
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v6 15/36] tcg: Add guest load/store primitives for TCGv_i128 |
|
Date: |
Wed, 1 Feb 2023 09:03:53 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
On 1/31/23 23:52, Alex Bennée wrote:
+ tcg_debug_assert((mop & (MO_BSWAP|MO_SSIZE)) == (MO_LE|MO_128));
Why not use validate_memop for this like elsewhere in cputlb?
validate_memop is going away; this patch was pulled forward from that.
I'm confused because the TCG ops in this patch are still using i64 and
the atomic use hasn't come in yet. Worth splitting the patch?
I'm confused about what sort of split you're suggesting.
The non-atomic use comes in with the very next patch in this series...
r~