qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: fix q35 kernel measurements broken due to rng seeding


From: Peter Maydell
Subject: Re: [PATCH] x86: fix q35 kernel measurements broken due to rng seeding
Date: Wed, 1 Feb 2023 16:50:43 +0000

On Wed, 1 Feb 2023 at 15:25, James Bottomley <jejb@linux.ibm.com> wrote:
>
> On Wed, 2023-02-01 at 10:10 -0500, Jason A. Donenfeld wrote:
> > This is already fixed via the patch that MST just sent in his pull.
> > So wait a few days for that to be merged and it'll be all set.
> >
> > No need for this patch here. Do not merge.
>
> If it's not a secret, would it be too much trouble to point to the
> branch so we can actually test it?  It does seem that the biggest
> problem this issue shows is that there wasn't wide enough configuration
> testing done on the prior commits before they were merged.

In general you shouldn't expect commits to be visible in
a git branch before they get merged -- the QEMU process
is not exactly identical to the kernel one.

For a particular patch on the mailing list, you can get a git branch
with it applied by looking for the patch in https://patchew.org/QEMU/
if that's more convenient than just applying it by hand.

We also don't tend to want patches hanging around for testing
before they get merged[*] -- we figure that "in upstream git"
is the place that actually gets tested in practice; almost
nobody will be working with or testing anything else.

[*] The fix Jason refers to here that's in MST's pullreq
unfortunately hasn't made it upstream as quickly as I
would like, due to a combination of things including us
having to pause CI for a week when we ran out of minutes.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]