[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] Remove C virtiofsd
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 0/3] Remove C virtiofsd |
Date: |
Wed, 18 Jan 2023 10:59:30 -0500 |
On Wed, 18 Jan 2023 at 10:40, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a
> in v7.0 in favour of the Rust implementation at
>
> https://gitlab.com/virtio-fs/virtiofsd
>
> since then, the Rust version has had more development and
> has held up well. It's time to say goodbye to the C version
> that got us going.
>
> The only thing I've not cleaned up here is
> tests/avocado/virtiofs_submounts.py
>
> which I guess needs to figure out where the virtiofsd implementation
> is and use it; suggestions welcome.
I see something similar in tests/avocado/avocado_qemu/__init__.py:
# If qemu-img has been built, use it, otherwise the system wide one
# will be used. If none is available, the test will cancel.
qemu_img = os.path.join(BUILD_DIR, 'qemu-img')
if not os.path.exists(qemu_img):
qemu_img = find_command('qemu-img', False)
if qemu_img is False:
self.cancel('Could not find "qemu-img", which is required to '
'create the bootable image')
Maybe find_command('virtiofsd', False)?
Stefan