Re: [RFC PATCH v3 06/28] target/arm: Move cpregs code into cpregs.c

[Philippe Mathieu-Daudé]

On 13/1/23 15:03, Fabiano Rosas wrote:
> Code moved verbatim.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/arm/cpregs.c     | 9087 +++++++++++++++++++++++++++++++++++++++
>   target/arm/helper.c     | 9063 --------------------------------------

Nice diffstat...

>   target/arm/meson.build  |    1 +
>   target/arm/trace-events |    2 +-
>   4 files changed, 9089 insertions(+), 9064 deletions(-)
>   create mode 100644 target/arm/cpregs.c

> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index aa94db9917..0c3e72a266 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -31,5614 +31,9 @@

Can we remove the '#include "trace.h"' from helper.c?

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>   #endif
>   #include "cpregs.h"
>   
> -#define ARM_CPU_FREQ 1000000000 /* FIXME: 1 GHz, should be configurable */
>   
>   static void switch_mode(CPUARMState *env, int mode);


> diff --git a/target/arm/trace-events b/target/arm/trace-events
> index 2a0ba7bffc..04a480443e 100644
> --- a/target/arm/trace-events
> +++ b/target/arm/trace-events
> @@ -1,6 +1,6 @@
>   # See docs/devel/tracing.rst for syntax documentation.
>   
> -# helper.c
> +# cpregs.c
>   arm_gt_recalc(int timer, int irqstate, uint64_t nexttick) "gt recalc: timer %d 
> irqstate %d next tick 0x%" PRIx64
>   arm_gt_recalc_disabled(int timer) "gt recalc: timer %d irqstate 0 timer 
> disabled"
>   arm_gt_cval_write(int timer, uint64_t value) "gt_cval_write: timer %d value 
> 0x%" PRIx64