[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 39/46] softmmu/rtc: Emit warning when using driftfix=slew on syste
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 39/46] softmmu/rtc: Emit warning when using driftfix=slew on systems without mc146818 |
Date: |
Fri, 13 Jan 2023 16:45:25 +0100 |
From: Thomas Huth <thuth@redhat.com>
The 'slew' lost tick policy is only available on systems with a mc146818
RTC. On other systems, "-rtc driftfix=slew" is currently silently ignored.
Let's emit at least a warning in this case to make the users aware that
there is something wrong in their command line settings.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20230110095351.611724-5-thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
softmmu/rtc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/softmmu/rtc.c b/softmmu/rtc.c
index 7e2956f81e..f7114bed7d 100644
--- a/softmmu/rtc.c
+++ b/softmmu/rtc.c
@@ -33,6 +33,7 @@
#include "sysemu/replay.h"
#include "sysemu/sysemu.h"
#include "sysemu/rtc.h"
+#include "hw/rtc/mc146818rtc.h"
static enum {
RTC_BASE_UTC,
@@ -177,10 +178,13 @@ void configure_rtc(QemuOpts *opts)
value = qemu_opt_get(opts, "driftfix");
if (value) {
if (!strcmp(value, "slew")) {
- object_register_sugar_prop("mc146818rtc",
+ object_register_sugar_prop(TYPE_MC146818_RTC,
"lost_tick_policy",
"slew",
false);
+ if (!object_class_by_name(TYPE_MC146818_RTC)) {
+ warn_report("driftfix 'slew' is not available with this
machine");
+ }
} else if (!strcmp(value, "none")) {
/* discard is default */
} else {
--
2.38.1
- [PULL 28/46] mips: Always include nanomips disassembler, (continued)
- [PULL 28/46] mips: Always include nanomips disassembler, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 29/46] hw/pci/pci_host: Trace config accesses on unexisting functions, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 30/46] hw/pci/pci: Factor out pci_bus_map_irqs() from pci_bus_irqs(), Philippe Mathieu-Daudé, 2023/01/13
- [PULL 31/46] hw/isa/piix3: Decouple INTx-to-LNKx routing which is board-specific, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 32/46] hw/isa/piix4: Decouple INTx-to-LNKx routing which is board-specific, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 33/46] hw/mips/Kconfig: Track Malta's PIIX dependencies via Kconfig, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 35/46] hw/intc/i8259: Make using the isa_pic singleton more type-safe, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 34/46] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 36/46] hw/intc: Extract the IRQ counting functions into a separate file, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 38/46] hw/rtc/mc146818rtc: Make the mc146818 RTC device target independent, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 39/46] softmmu/rtc: Emit warning when using driftfix=slew on systems without mc146818,
Philippe Mathieu-Daudé <=
- [PULL 40/46] hw/pci-host/bonito: Convert to 3-phase reset, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 41/46] hw/pci-host/bonito: Use 'bonito_host' for PCI host bridge code, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 42/46] hw/pci-host/bonito: Use 'bonito_pci' for PCI function #0 code, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 44/46] hw/mips/boston: Rename MachineState 'mc' pointer to 'ms', Philippe Mathieu-Daudé, 2023/01/13
- [PULL 43/46] hw/pci-host/bonito: Declare TYPE_BONITO_PCI_HOST_BRIDGE in header, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 37/46] hw/core/qdev-properties-system: Allow the 'slew' policy only on x86, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 46/46] scripts/git.orderfile: Display MAINTAINERS changes first, Philippe Mathieu-Daudé, 2023/01/13
- [PULL 45/46] target/mips: Restrict 'qapi-commands-machine.h' to system emulation, Philippe Mathieu-Daudé, 2023/01/13
- Re: [PULL 00/46] MIPS patches for 2023-01-13, Peter Maydell, 2023/01/13