[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 15/17] ui: Don't check for mode change after mouse_set error
From: |
Markus Armbruster |
Subject: |
[PATCH v4 15/17] ui: Don't check for mode change after mouse_set error |
Date: |
Mon, 9 Jan 2023 20:03:19 +0100 |
hmp_mouse_set() doesn't bail out when it can't find a mouse.
Harmless, since qemu_input_check_mode_change() should be a no-op then.
Clean it up anyway.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
ui/input.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/input.c b/ui/input.c
index 8f4a87d1d7..d1c7605238 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -616,6 +616,7 @@ void hmp_mouse_set(Monitor *mon, const QDict *qdict)
if (!found) {
error_report("Mouse at index '%d' not found", index);
+ return;
}
qemu_input_check_mode_change();
--
2.39.0
- Re: [PATCH v4 16/17] ui: Split hmp_mouse_set() and move the HMP part to ui/, (continued)
- [PATCH v4 06/17] ui/spice: QXLInterface method set_mm_time() is now dead, drop, Markus Armbruster, 2023/01/09
- [PATCH v4 08/17] ui: Clean up a few things checkpatch.pl would flag later on, Markus Armbruster, 2023/01/09
- [PATCH v4 11/17] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c, Markus Armbruster, 2023/01/09
- [PATCH v4 17/17] ui: Simplify control flow in qemu_mouse_set(), Markus Armbruster, 2023/01/09
- [PATCH v4 09/17] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c, Markus Armbruster, 2023/01/09
- [PATCH v4 07/17] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage, Markus Armbruster, 2023/01/09
- [PATCH v4 10/17] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c, Markus Armbruster, 2023/01/09
- [PATCH v4 15/17] ui: Don't check for mode change after mouse_set error,
Markus Armbruster <=
- [PATCH v4 01/17] ui: Check numeric part of expire_password argument @time properly, Markus Armbruster, 2023/01/09
- [PATCH v4 12/17] ui: Improve "change vnc" error reporting, Markus Armbruster, 2023/01/09
- [PATCH v4 13/17] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c, Markus Armbruster, 2023/01/09
- [PATCH v4 03/17] ui/spice: Require spice-protocol >= 0.14.0, Markus Armbruster, 2023/01/09