qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-8.0 2/2] hw: Reduce "qemu/accel.h" inclusion


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-8.0 2/2] hw: Reduce "qemu/accel.h" inclusion
Date: Wed, 30 Nov 2022 16:43:16 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0

On 30/11/22 16:17, Fabiano Rosas wrote:
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

Move "qemu/accel.h" include from the heavily included
"hw/boards.h" to hw/core/machine.c, the single file using
the AccelState definition.

Do you mean accel_init_interfaces() and ACCEL_GET_CLASS? I don't see
AccelState explicitly.

Oops you are right...

Paolo, do you mind fixing with:

   Move "qemu/accel.h" include from the heavily included
   "hw/boards.h" to hw/core/machine.c, the single file using
   accel-related definitions.

or do you want me to respin a v2?

Anyway,

Reviewed-by: Fabiano Rosas <farosas@suse.de>

Thanks!

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  hw/core/machine.c   | 1 +
  include/hw/boards.h | 1 -
  2 files changed, 1 insertion(+), 1 deletion(-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]