qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.2] target/arm: Set TCGCPUOps.restore_state_to_opc for v


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH for-7.2] target/arm: Set TCGCPUOps.restore_state_to_opc for v7m
Date: Wed, 30 Nov 2022 09:37:55 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0

On 29/11/22 21:41, Richard Henderson wrote:
This setting got missed, breaking v7m.

Fixes: 56c6c98df85c ("target/arm: Convert to tcg_ops restore_state_to_opc")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1347
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
  target/arm/internals.h | 4 ++++
  target/arm/cpu.c       | 6 +++---
  target/arm/cpu_tcg.c   | 1 +
  3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/target/arm/cpu_tcg.c b/target/arm/cpu_tcg.c
index 60ff539fa1..9a2cef7d05 100644
--- a/target/arm/cpu_tcg.c
+++ b/target/arm/cpu_tcg.c
@@ -1035,6 +1035,7 @@ static const struct TCGCPUOps arm_v7m_tcg_ops = {
      .initialize = arm_translate_init,
      .synchronize_from_tb = arm_cpu_synchronize_from_tb,
      .debug_excp_handler = arm_debug_excp_handler,
+    .restore_state_to_opc = arm_restore_state_to_opc,

Oops indeed :/

I double checked, arm_v7m_tcg_ops is the single TCGCPUOps missed.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]