[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/5] Add qemu-img checksum command using blkhash
From: |
Nir Soffer |
Subject: |
[PATCH v2 0/5] Add qemu-img checksum command using blkhash |
Date: |
Mon, 28 Nov 2022 16:15:09 +0200 |
Since blkhash is available only via copr now, the new command is added as
optional feature, built only if blkhash-devel package is installed.
Changes since v1 (Hanna):
- Move IO_BUF_SIZE to top of the file
- Extend TestFinder to support format or cache specific out files
- Improve online help (note about optimization and lint to blkhash project)
- Guard blkhash.h include with CONFIG_BLKHASH
- Using user_creatable_process_cmdline() instead of
user_creatable_add_from_str()
- Rename ret to exit_code
- Add static assert to ensure that read buffer is algined to block size
- Drop unneeded pnum variable
- Change test to work like other tests; use iotest.imgfmt and iotest.cachemode
- Simplify test to test only raw and qcow2 format using file protocol
- Fix code style issues (multi-line comments, missing braces)
- Make error checking more clear (checksum_block_status(s) < 0)
v1:
https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html
v1 discussion:
- https://lists.nongnu.org/archive/html/qemu-block/2022-10/msg00602.html
- https://lists.nongnu.org/archive/html/qemu-block/2022-10/msg00603.html
- https://lists.nongnu.org/archive/html/qemu-block/2022-10/msg00604.html
- https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00171.html
- https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00173.html
Nir Soffer (5):
qemu-img.c: Move IO_BUF_SIZE to the top of the file
Support format or cache specific out file
qemu-img: Add checksum command
iotests: Test qemu-img checksum
qemu-img: Speed up checksum
docs/tools/qemu-img.rst | 24 ++
meson.build | 10 +-
meson_options.txt | 2 +
qemu-img-cmds.hx | 8 +
qemu-img.c | 390 +++++++++++++++++-
tests/qemu-iotests/findtests.py | 10 +-
tests/qemu-iotests/tests/qemu-img-checksum | 63 +++
.../tests/qemu-img-checksum.out.qcow2 | 11 +
.../tests/qemu-img-checksum.out.raw | 10 +
9 files changed, 523 insertions(+), 5 deletions(-)
create mode 100755 tests/qemu-iotests/tests/qemu-img-checksum
create mode 100644 tests/qemu-iotests/tests/qemu-img-checksum.out.qcow2
create mode 100644 tests/qemu-iotests/tests/qemu-img-checksum.out.raw
--
2.38.1
- [PATCH v2 0/5] Add qemu-img checksum command using blkhash,
Nir Soffer <=
- [PATCH v2 5/5] qemu-img: Speed up checksum, Nir Soffer, 2022/11/28
- [PATCH v2 3/5] qemu-img: Add checksum command, Nir Soffer, 2022/11/28
- [PATCH v2 4/5] iotests: Test qemu-img checksum, Nir Soffer, 2022/11/28
- [PATCH v2 1/5] qemu-img.c: Move IO_BUF_SIZE to the top of the file, Nir Soffer, 2022/11/28
- [PATCH v2 2/5] Support format or cache specific out file, Nir Soffer, 2022/11/28