|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH v6 03/14] nbd/server.c: add missing coroutine_fn annotations |
Date: | Fri, 25 Nov 2022 20:11:02 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 |
On 11/25/22 16:35, Emanuele Giuseppe Esposito wrote:
These functions end up calling bdrv_*() implemented as generated_co_wrapper functions. In addition, they also happen to be always called in coroutine context, meaning all callers are coroutine_fn. This means that the g_c_w function will enter the qemu_in_coroutine() case and eventually suspend (or in other words call qemu_coroutine_yield()). Therefore we need to mark such functions coroutine_fn too.
Same here about "need" and "missing".
Signed-off-by: Emanuele Giuseppe Esposito<eesposit@redhat.com> Reviewed-by: Kevin Wolf<kwolf@redhat.com> Reviewed-by: Paolo Bonzini<pbonzini@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |