qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] e1000e: Remove pending interrupt flags


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] e1000e: Remove pending interrupt flags
Date: Fri, 25 Nov 2022 15:08:40 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0

On 25/11/22 15:02, Akihiko Odaki wrote:
They are duplicate of running throttling timer flags and incomplete as
the flags are not cleared when the interrupts are fired or the device is
reset.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
  hw/net/e1000e_core.h |  2 --
  hw/net/e1000e.c      |  3 ---
  hw/net/e1000e_core.c | 19 +++----------------
  hw/net/trace-events  |  2 --
  4 files changed, 3 insertions(+), 23 deletions(-)

diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c
index 7523e9f5d2..459b12407a 100644
--- a/hw/net/e1000e.c
+++ b/hw/net/e1000e.c
@@ -630,12 +630,9 @@ static const VMStateDescription e1000e_vmstate = {
          VMSTATE_E1000E_INTR_DELAY_TIMER(core.tidv, E1000EState),
VMSTATE_E1000E_INTR_DELAY_TIMER(core.itr, E1000EState),
-        VMSTATE_BOOL(core.itr_intr_pending, E1000EState),
VMSTATE_E1000E_INTR_DELAY_TIMER_ARRAY(core.eitr, E1000EState,
                                                E1000E_MSIX_VEC_NUM),
-        VMSTATE_BOOL_ARRAY(core.eitr_intr_pending, E1000EState,
-                           E1000E_MSIX_VEC_NUM),
VMSTATE_UINT32(core.itr_guest_value, E1000EState),
          VMSTATE_UINT32_ARRAY(core.eitr_guest_value, E1000EState,

IIUC any changes to the VMState imply changing its version:
https://www.qemu.org/docs/master/devel/migration.html#versions



reply via email to

[Prev in Thread] Current Thread [Next in Thread]