Re: [RFC PATCH 1/3] hw/intc: Add missing include for goldfish_pic.h

[Philippe Mathieu-Daudé]

On 24/11/22 22:29, Jiaxun Yang wrote:
> hw/sysbus.h is missed in goldfish_pic.h.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   include/hw/intc/goldfish_pic.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/hw/intc/goldfish_pic.h b/include/hw/intc/goldfish_pic.h
> index e9d552f796..3e79580367 100644
> --- a/include/hw/intc/goldfish_pic.h
> +++ b/include/hw/intc/goldfish_pic.h
> @@ -10,6 +10,8 @@
>   #ifndef HW_INTC_GOLDFISH_PIC_H
>   #define HW_INTC_GOLDFISH_PIC_H

Also:

   #include "qom/object.h"
   #include "exec/memory.h"

> +#include "hw/sysbus.h"
> +
>   #define TYPE_GOLDFISH_PIC "goldfish_pic"
>   OBJECT_DECLARE_SIMPLE_TYPE(GoldfishPICState, GOLDFISH_PIC)
>