Re: [PULL 0/4] Fixes 20221124 patches

[Peter Maydell]

On Fri, 25 Nov 2022 at 06:34, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Thu, Nov 24, 2022 at 01:03:21PM -0500, Stefan Hajnoczi wrote:
> > On Thu, 24 Nov 2022 at 02:27, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > > usb+ui: fixes for 7.2
> >
> > Hi Gerd,
> > I already applied your previous pull request so these patches are in
> > qemu.git/master. Do you want to revert the 8.0 patches that were
> > included in your previous pull request? I don't know how risky it is
> > to have them in 7.2. It's up to you.
> >
> > 7d3cf19548 hw/audio/intel-hda: Drop unnecessary prototype
> > 3e95ef49e6 hw/audio/intel-hda: don't reset codecs twice
> > 1dfb7a175f hw/usb/hcd-xhci: Reset the XHCIState with device_cold_reset()
>
> They look rather safe to me, Peter raised concerns though so I've
> re-sent the pull with them dropped.
>
> Peter?

Stefan's point is that they're already upstream, so if you don't
want them you now need to send a pull with reverts in.

I think the patches should be OK, but the trouble with all
this reset stuff is that there are sometimes hidden
dependencies on exact ordering or I missed some interaction
with an old bit of the reset handling; and basic 'make check'
style testing doesn't always catch "this works fine until
the guest is rebooted and then it breaks on reboot" or
similar scenarios. So I was targeting 8.0 as the "safe option".

thanks
-- PMM