Re: [PATCH for-8.0 v3 14/45] tcg: Introduce tcg_type_size

[Richard Henderson]

On 11/22/22 10:14, Philippe Mathieu-Daudé wrote:
> > > I'd feel safer if we assign TCG_TYPE_I32 .. TCG_TYPE_V256 in TCGType,
> > > just in case.
> >
> > What do you mean?
>
> -- >8 --
> diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
> @@ -289,8 +289,8 @@ typedef struct TCGPool {
>   typedef enum TCGType {
> -    TCG_TYPE_I32,
> -    TCG_TYPE_I64,
> +    TCG_TYPE_I32  = 0,
> +    TCG_TYPE_I64  = 1,
>
> -    TCG_TYPE_V64,
> -    TCG_TYPE_V128,
> -    TCG_TYPE_V256,
> +    TCG_TYPE_V64  = 2,
> +    TCG_TYPE_V128 = 3,
> +    TCG_TYPE_V256 = 4,

But that's what C does.  I don't see the point.


r~