[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vhost-vdpa: skip TPM CRB memory section
From: |
Eric Auger |
Subject: |
Re: [PATCH] vhost-vdpa: skip TPM CRB memory section |
Date: |
Tue, 22 Nov 2022 17:05:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 |
Hi Marc-André,
On 11/22/22 15:53, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> 851d6d1a0f ("vfio/common: remove spurious tpm-crb-cmd misalignment
> warning") removed the warning on vfio_listener_region_add() path.
>
> An error is reported for vhost-vdpa case:
> qemu-kvm: vhost_vdpa_listener_region_add received unaligned region
>
> Skip the CRB device.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=2141965
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> hw/virtio/vhost-vdpa.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 7468e44b87..9d7206e4b8 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -19,6 +19,7 @@
> #include "hw/virtio/virtio-net.h"
> #include "hw/virtio/vhost-shadow-virtqueue.h"
> #include "hw/virtio/vhost-vdpa.h"
> +#include "sysemu/tpm.h"
> #include "exec/address-spaces.h"
> #include "migration/blocker.h"
> #include "qemu/cutils.h"
> @@ -46,6 +47,11 @@ static bool
> vhost_vdpa_listener_skipped_section(MemoryRegionSection *section,
> {
> Int128 llend;
>
> + if (TPM_IS_CRB(section->mr->owner)) {
> + /* The CRB command buffer has its base address unaligned. */
> + return true;
> + }
> +
> if ((!memory_region_is_ram(section->mr) &&
> !memory_region_is_iommu(section->mr)) ||
> memory_region_is_protected(section->mr) ||
- [PATCH] vhost-vdpa: skip TPM CRB memory section, marcandre . lureau, 2022/11/22
- Re: [PATCH-for-7.2] vhost-vdpa: skip TPM CRB memory section, Philippe Mathieu-Daudé, 2022/11/22
- Re: [PATCH] vhost-vdpa: skip TPM CRB memory section,
Eric Auger <=
- Re: [PATCH] vhost-vdpa: skip TPM CRB memory section, Eugenio Perez Martin, 2022/11/22
- Re: [PATCH] vhost-vdpa: skip TPM CRB memory section, Michael S. Tsirkin, 2022/11/22
- Re: [PATCH] vhost-vdpa: skip TPM CRB memory section, Eugenio Perez Martin, 2022/11/23
- Re: [PATCH] vhost-vdpa: skip TPM CRB memory section, Michael S. Tsirkin, 2022/11/23